Thierry Laurion<p><span class="h-card" translate="no"><a href="https://mas.to/@libreleah" class="u-url mention" rel="nofollow noopener noreferrer" target="_blank">@<span>libreleah</span></a></span> <span class="h-card" translate="no"><a href="https://mas.to/@mkukri" class="u-url mention" rel="nofollow noopener noreferrer" target="_blank">@<span>mkukri</span></a></span> </p><p>Both Heads and lbmk permit to apply patches on top of a coreboot fork. </p><p>The difference between the two here is that lbmk builds the tree, clean, for each boards, where Heads applies the patches to a fork once, and each board reuses fork build artifacts;, building board specifics in a board specific artifact directory. That permits crossgcc, being the buildstack of each coreboot fork version to be built once, and also repro build issues upstream, economizing both disk space, cpu resource for user and CI.</p><p>In Heads goal of building fully functional roms, CI can build and stitch reproducible roms for each commit for end users to download directly from CI, for each commit, and see if a comit broke a built, for each commit. CI cache is reused, so that we don't waste CI resources either.</p><p>In the case of t480, the patch was made with lbmk in mind, not coreboot nor Heads, and breaks other thinkpads in coreboot upstream, trying to not only build for t480 but make sure t480 patchset doesn't break other boards. In this case, it breaks all other thinkpads, so prevent Heads from merging the PR. What you propose here is for libreboot and Heads to maintain a patchset not merged upstream; it might suit libreboot mindset, being more bleeding edge, and minifree, selling the t480, but not Heads. Heads tries to stay as close as possible to upstream forks, and pushes upstream projects to merge patches. Its long, not easy, but the right thing to do. The patches stays in a patch dir for everyone to see, per software version. In this case, patches/coreboot-24.12/*</p><p>I tried to apply the following patch without success instead of commenting thermal.asl</p><p>+diff --git a/src/ec/lenovo/h8/acpi/ec.asl b/src/ec/lenovo/h8/acpi/ec.asl<br>+index bc54d3b..a0408c8 100644<br>+--- a/src/ec/lenovo/h8/acpi/ec.asl<br>++++ b/src/ec/lenovo/h8/acpi/ec.asl<br>+@@ -331,7 +331,13 @@ Device(EC)<br>+ <a href="https://infosec.exchange/tags/include" class="mention hashtag" rel="nofollow noopener noreferrer" target="_blank">#<span>include</span></a> "sleepbutton.asl"<br>+ <a href="https://infosec.exchange/tags/include" class="mention hashtag" rel="nofollow noopener noreferrer" target="_blank">#<span>include</span></a> "lid.asl"<br>+ <a href="https://infosec.exchange/tags/include" class="mention hashtag" rel="nofollow noopener noreferrer" target="_blank">#<span>include</span></a> "beep.asl"<br>++<br>++<a href="https://infosec.exchange/tags/ifndef" class="mention hashtag" rel="nofollow noopener noreferrer" target="_blank">#<span>ifndef</span></a> CONFIG_BOARD_LENOVO_T480<br>+ <a href="https://infosec.exchange/tags/include" class="mention hashtag" rel="nofollow noopener noreferrer" target="_blank">#<span>include</span></a> "thermal.asl"<br>++<a href="https://infosec.exchange/tags/else" class="mention hashtag" rel="nofollow noopener noreferrer" target="_blank">#<span>else</span></a><br>++//#include "thermal.asl"<br>++<a href="https://infosec.exchange/tags/endif" class="mention hashtag" rel="nofollow noopener noreferrer" target="_blank">#<span>endif</span></a><br>++<br>+ <a href="https://infosec.exchange/tags/include" class="mention hashtag" rel="nofollow noopener noreferrer" target="_blank">#<span>include</span></a> "systemstatus.asl"<br>+ <a href="https://infosec.exchange/tags/include" class="mention hashtag" rel="nofollow noopener noreferrer" target="_blank">#<span>include</span></a> "thinkpad.asl"<br>+ }</p><p>Other non t480 fail to build, and I have no more time to spend on this. The community is interested, tried to reach libreboot and were seen as spammers.</p><p>Please fix your patchset upstream. People saw the t480 being "supported by coreboot" in a talk. People didn't understand it was a WiP patchset under coreboot. And here we are. 24.12 was december 2024 "release", there will be another one in 25.03... I do not have time to maintain patches on top of patches, Leah. My focus is not to be a coreboot distribution. My focus is to deliver reproducible roms to users needing accessible security, and improve that UX. There is no grub/seabios under Heads, my focus is to make upstream do the right thing and participate upstream, and make contributors participate upstream. Here, you stated loud and clear tha libreboot comes first before coreboot, I respect that. But the t480 patchset is the one too from upstream. That upstream patch needs to build, and then will be merged and then you won't have to maintain it either. And others will fix audio issues, nvidia etc. Otherwise its silo work, and i'm not interested in that anymore</p><p>---</p><p>Yes, there is different coreboot forks specified in a central place: modules/coreboot. </p><p>And there, the buildsystem says if it can reuse crossgcc of another fork to fasten builds for each commit. The idea here is that the user building one board, or multiple boards will get the same result, but CI building multiple boards based on the same fork will speed up builds massively.</p><p>d16 will move to fam15h fork from other community effort. I mentor now, I don't try to do everything myself. Just as here, trying tto collaborate with you so you fix what was brought up upstream. But up to now, you are upstream for t480.</p><p>The goal here was not to compare our buildsystems, simply stating that the patchset upstream will never be merged if it causes regressions building other boards. Libreboot can do what it wants, but needs to respect how coreboot works. Their CI does the same, and make sure that building a commit for a board won't break others. In current case, it breaks others and needs to be updated.</p><p>This needs to be fixed upstream at <a href="https://review.coreboot.org/c/coreboot/+/83274" rel="nofollow noopener noreferrer" translate="no" target="_blank"><span class="invisible">https://</span><span class="ellipsis">review.coreboot.org/c/coreboot</span><span class="invisible">/+/83274</span></a></p>